RFR : 8219746: Provide virtualization related info in the hs_error file on linux ppc64 / ppc64le

[Schmidt, Lutz]

Hi Matthias, 

your change looks good to me. I'm not a reviewer, though. 

Thanks for improving the virtualization info. It will be very helpful in understanding why a system is not performing the way it is expected to. 

Regards,
Lutz


On 28.02.19, 09:14, "hotspot-dev on behalf of Baesken, Matthias" <hotspot-dev-bounces at openjdk.java.net on behalf of matthias.baesken at sap.com> wrote:

    Hi David, thanks for the review .
    
    > Changes seem okay. I'm a little surprised this is architecture specific,
    
    I do not see the file  lparcfg  on our x86_64  and s390  Linux machines.
    
    And
    
    https://manpages.debian.org/testing/powerpc-ibm-utils/lparcfg.5.en.html
    
    states :
    
    "The lparcfg file is a virtual file which contains information related to an IBM Power Logical Partition."
    
    
    So it seems that it is really  (IBM)   Power   (ppc64)  specific .
    
    Best regards, Matthias
    
    
    
    > -----Original Message-----
    > From: David Holmes <david.holmes at oracle.com>
    > Sent: Donnerstag, 28. Februar 2019 06:26
    > To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
    > dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
    > Cc: Steiner, Andreas <a.steiner at sap.com>
    > Subject: Re: RFR : 8219746: Provide virtualization related info in the hs_error
    > file on linux ppc64 / ppc64le
    > 
    > Hi Matthias,
    > 
    > On 28/02/2019 2:59 am, Baesken, Matthias wrote:
    > > Hello,
    > >      please review  the following  change ; it adds  virtualization related info in
    > the hs_error file on linux  ppc64 / ppc64le .
    > 
    > Changes seem okay. I'm a little surprised this is architecture specific,
    > but it's not something I'm familiar with. If we get another variant of
    > this for another arch it will be time to move it into the arch specific
    > files.
    > 
    > Thanks,
    > David
    > 
    > > On linux  ppc64 / ppc64le  , we often  run in virtualized environments
    > (Power KVM / Power VM ... ).
    > > It is helpful for instance in support cases to get some information about the
    > virtualized environment in the hs_error file .
    > >
    > > Bug/webrev :
    > >
    > > https://bugs.openjdk.java.net/browse/JDK-8219746
    > >
    > > http://cr.openjdk.java.net/~mbaesken/webrevs/8219746.0/
    > >