RFR [XS]: 8215961: jdk/jfr/event/os/TestCPUInformation.java fails on AArch64

[Lindenmaier, Goetz]

Looks good, thanks!

Best
Götz 

> Am 03.01.2019 um 16:39 schrieb Baesken, Matthias <matthias.baesken at sap.com>:
> 
> Hello,   here is  the second webrev  :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8215961.1/
> 
> I adjusted s390  as well .
> 
> Best regards, Matthias
> 
> 
> 
>> -----Original Message-----
>> From: Schmidt, Lutz
>> Sent: Donnerstag, 3. Januar 2019 15:47
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Baesken, Matthias
>> <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-
>> dev at openjdk.java.net>
>> Subject: Re: RFR [XS]: 8215961: jdk/jfr/event/os/TestCPUInformation.java
>> fails on AArch64
>> 
>> Hi,
>> I would suggest to replace "zArch" with "s390" to use the same term
>> everywhere.
>> There is reason for some hope this change will avoid confusion in the future.
>> Regards,
>> Lutz
>> 
>> On 03.01.19, 14:41, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com>
>> wrote:
>> 
>>    Hi Matthias,
>> 
>>    the change looks good to me.
>> 
>>    But looking at the code, I saw that s390 says "zArch" there.
>>    We use the string "s390" throughout the code to name the platform,
>>    so I think this should say "s390". In documentation, we use
>> "z/Architecture",
>>    as well as in some version messages.  So this would also be an option.
>>    Could you fix this too, please?  And adapt the test?
>>    @Lutz, what do you think?
>> 
>>    Best regards,
>>      Goetz.
>> 
>>> -----Original Message-----
>>> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On
>> Behalf Of
>>> Baesken, Matthias
>>> Sent: Freitag, 28. Dezember 2018 14:36
>>> To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
>>> Subject: RFR [XS]: 8215961: jdk/jfr/event/os/TestCPUInformation.java
>> fails on
>>> AArch64
>>> 
>>> Hello, please review this small  fix .
>>> 
>>> At the moment,  the test    jdk/jfr/event/os/TestCPUInformation.java
>> fails
>>> on AArch64 with the following error :
>>> 
>>> 
>>> java.lang.RuntimeException: Value not in (Intel, AMD, Unknown x86,
>> SPARC,
>>> ARM, PPC, PowerPC, AArch64, zArch), field='description',
>>> value='0x50:0x0:0x000:1, simd'
>>> 
>>> 
>>> Reason is that  the  jdk.CPUInformation   event misses  a known CPU
>>> identifier value  in the  description,  see the  description part of it  :
>>> 
>>> Event: jdk.CPUInformation {
>>>   ....
>>>  description = "0x50:0x0:0x000:1, simd"
>>>  sockets = 8
>>>  ....
>>> }
>>> 
>>> 
>>> The patch adds  the CPU identifier info to  the   _cpu_desc   string  where
>> it is
>>> taken from   .
>>> Please compare also with the ppc - implementation where the info  (PPC)
>> is
>>> already added .
>>> 
>>> vm_version_ext_ppc.cpp
>>> 
>>> 50     snprintf(_cpu_desc, CPU_DETAILED_DESC_BUF_SIZE, "PPC %s",
>>> features_string());
>>> 
>>> 
>>> 
>>> Bug/webrev :
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8215961
>>> 
>>> http://cr.openjdk.java.net/~mbaesken/webrevs/8215961.0/
>>> 
>>> 
>>> Thanks, Matthias
>> 
>> 
>