RFR 8216010: Change callers of build_u2_from() to call Bytes::get_Java_u2() instead

Harold David Seigel harold.seigel at oracle.com
Fri Jan 4 12:49:15 UTC 2019


Thanks Coleen!

Harold

On 1/4/2019 7:45 AM, coleen.phillimore at oracle.com wrote:
> Looks nice!
> Coleen
>
> On 1/3/19 11:23 PM, Jiangli Zhou wrote:
>> +1
>>
>> Thanks,
>>
>> Jiangli
>>
>>
>> On 1/3/19 7:47 PM, Kim Barrett wrote:
>>>> On Jan 3, 2019, at 4:53 PM, Harold David Seigel 
>>>> <harold.seigel at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review this small fix for JDK-8216010.  The fix removes 
>>>> function build_u2_from() and changes its callers to call function 
>>>> Bytes::get_Java_u2().
>>>>
>>>> Open Webrev: 
>>>> http://cr.openjdk.java.net/~hseigel/bug_8216010/webrev/index.html
>>>>
>>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8216010
>>>>
>>>> The fix was regression tested by running Mach5 tiers 1 and 2 tests 
>>>> and builds on Linux-x64, Windows, and Mac OS X, running Mach5 tiers 
>>>> 3 - 5 on Linux-x64, and by running JCK-12 Lang and VM tests on 
>>>> Linux-x64.
>>>>
>>>> Thanks, Harold
>>> Looks good.
>>>
>>
>


More information about the hotspot-dev mailing list