RFR (tedious) 8216022: Use #pragma once

[Baesken, Matthias]

Hello,  probably we need an update  to   jdk/doc/building.html as well because  this still documents  12.4  

 ...
Oracle Solaris Studio
The minimum accepted version of the Solaris Studio compilers is 5.13 (corresponding to Solaris Studio 12.4). Older versions will not be accepted by configure.
The Solaris Studio installation should contain at least these packages:  ...
 ....

Best regards, Matthias


> -----Original Message-----
> From: Daniel D. Daugherty <daniel.daugherty at oracle.com>
> Sent: Freitag, 4. Januar 2019 15:19
> To: Erik Österlund <erik.osterlund at oracle.com>; Baesken, Matthias
> <matthias.baesken at sap.com>; hotspot-dev at openjdk.java.net
> Subject: Re: RFR (tedious) 8216022: Use #pragma once
> 
> Since Solaris-X64 is currently stuck at Oracle Studio 12u4
> due to the lack of a devkit, this change will break the
> ability to build and test on Solaris-X64.
> 
> Dan
> 
> 
> On 1/4/19 4:38 AM, Erik Österlund wrote:
> > Hi Matthias,
> >
> > The #pragma once support was added in Oracle Studio 12u5, which is
> > what I have been patiently been waiting for. Having said that, I would
> > recommend using 12u6.
> >
> > Thanks for confirming that xlc 12.1 / AIX works.
> >
> > /Erik
> >
> > On 2019-01-04 08:57, Baesken, Matthias wrote:
> >> Hello   Coleen,   on Solaris  Sparc with  Oracle Studio  12u4
> >> Oct2017  version   we get
> >>
> >> " line 25: Error: Unrecognized #pragma once"
> >>
> >> Which  Oracle Studio version do you recommend to use  ?
> >>
> >>
> >> (good news is  that xlc 12.1  / AIX  works )
> >>
> >>
> >> Best regards, Matthias
> >>
> >>
> >>> Message: 2
> >>> Date: Wed, 2 Jan 2019 21:16:59 -0500
> >>> From: coleen.phillimore at oracle.com
> >>> To: hotspot-dev developers <hotspot-dev at openjdk.java.net>, John
> Paul
> >>>     Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
> >>> Subject: RFR (tedious) 8216022: Use #pragma once
> >>> Message-ID: <9250036e-8696-6103-6c3f-513fa11ffebd at oracle.com>
> >>> Content-Type: text/plain; charset=utf-8; format=flowed
> >>>
> >>> Summary: change include guards to #pragma once, except in generated
> >>> header files.
> >>>
> >>> Tested with mach5 for linux-x64{-debug}, solaris-sparc, macosx-x64,
> >>> windows-x64, built aarch64 with cross compiler, and zero.
> >>>
> >>> Ran tier1 and 2 tests.
> >>>
> >>> The webrev is huge but there are only 3 lines changed in each header
> >>> file.? So click on the patch.
> >>>
> >>> I'll update the copyright headers with a script with the commit. Also,
> >>> will do this after the shenandoah copyright headers are fixed.
> >>>
> >>> Adrian: I included you to check your platforms.
> >>>
> >>> Happy New Year!
> >>> Coleen
> >>>
> >>>
> >>> ------------------------------
> >> ....
> >>
> >>> Here is the webrev and bug link.
> >>>
> >>> open webrev at
> http://cr.openjdk.java.net/~coleenp/8216022.01/webrev
> >>> bug link https://bugs.openjdk.java.net/browse/JDK-8216022
> >>>
> >