RFR (also tedious) 8216167: Update include guards to reflect correct directories

[coleen.phillimore at oracle.com]

On 1/4/19 4:52 PM, Kim Barrett wrote:
>> On Jan 4, 2019, at 10:36 AM, coleen.phillimore at oracle.com wrote:
>>
>> Summary: Use script and some manual fixup to fix directores names in include guards.
>>
>> Makes include guards match the current directory rooted at src/hotspot (removes VM_ in most cases).
>>
>> This should be low risk.  Tested with mach5 tier1 and tier2.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8216167
>> http://cr.openjdk.java.net/~coleenp/8216167.01.diff
>>
>> I didn't generate a webrev as a space concern for cr.openjdk.java.net and nobody should click on it.  Script is posted in bug.  Will update and check copyright headers with hg commit.
>>
>> Thanks,
>> Coleen
> There are incorrect changes in src/hotspot/cpu/arm/globalDefinitions_arm.hpp

Thank you for finding this.
> The script is not being careful to *only* modify #include guards.  I didn’t look for other similar problems.
> (This is an example of why I suggested rolling your own script might not actually be easier than using
> the guardonce utilities.)
>
I looked through again and didn't see any other problems.  I'm not 
planning on productizing my script, which admittedly is too simple for 
the general job.  But I still found it useful and entertaining (to me) 
for this particular task.

http://cr.openjdk.java.net/~coleenp/8216167.01.diff.02

Thanks,
Coleen