RFR (XS): 8216366: Add rationale to PER_CPU_SHARES define
Andrew Dinn
adinn at redhat.com
Tue Jan 8 15:54:05 UTC 2019
On 08/01/2019 15:15, Severin Gehwolf wrote:
> On Tue, 2019-01-08 at 08:31 -0500, Bob Vandette wrote:
>> I don’t know how folks feel about embedding possible bit-rotting URLs in the sources but
>> it looks good to me.
>
> I've considered that. Then concluded that URLs might be useful even if
> they bitrot (in times like wayback machine and such).
>
>> Thanks for doing this.
>
> Thanks for the review Bob!
>
> Any Reviewers care to comment on this? Can I consider this a trivial
> change?
It looks pretty trivial to me. If not then consider this a review :-)
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
More information about the hotspot-dev
mailing list