RFR (XS): 8216366: Add rationale to PER_CPU_SHARES define

Severin Gehwolf sgehwolf at redhat.com
Tue Jan 8 16:08:16 UTC 2019


On Tue, 2019-01-08 at 15:54 +0000, Andrew Dinn wrote:
> On 08/01/2019 15:15, Severin Gehwolf wrote:
> > On Tue, 2019-01-08 at 08:31 -0500, Bob Vandette wrote:
> > > I don’t know how folks feel about embedding possible bit-rotting URLs in the sources but
> > > it looks good to me.  
> > 
> > I've considered that. Then concluded that URLs might be useful even if
> > they bitrot (in times like wayback machine and such).
> > 
> > > Thanks for doing this.
> > 
> > Thanks for the review Bob!
> > 
> > Any Reviewers care to comment on this? Can I consider this a trivial
> > change?
> 
> It looks pretty trivial to me. If not then consider this a review :-)

Thanks Andrew!

Cheers,
Severin



More information about the hotspot-dev mailing list