RFR (S/M): 8213827: NUMA heap allocation does not respect process membind/interleave settings [Was: Re: [PATCH] JDK NUMA Interleaving issue]

[sangheon.kim at oracle.com]

Hi Thomas,

On 12/13/18 2:33 AM, Thomas Schatzl wrote:
> Hi Amit,
> On Thu, 2018-12-13 at 15:11 +0530, amith pawar wrote:
>> Hi Thomas,
>>
>> Please find the attached patch updated as per your suggestion.
>> If everything OK then can you please commit this to repo ?
>    looks good. We will need a second reviewer though, I am going to ask
> around.
>
> Latest webrev:
> http://cr.openjdk.java.net/~tschatzl/8213827/webrev.3/
Webrev.3 looks good to me.

I have some minor nits:
----------------------------------------
src/hotspot/os/linux/os_linux.cpp
5012       for (int node = 0; node < Linux::numa_max_node(); node++) {
- Looks like 'node <*_=_* Linux::numa_max_node()' is the right one to 
print the latest node?

----------------------------------------
src/hotspot/os/linux/os_linux.hpp
  271   enum Numa_allocation_policy{
- Looking at 'enum' at os.hpp, we use Camel style.
- There are missing space before '{'.

- As usual, copyright year updates. I know it was correct when you 
posted. :)

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>
>