RFR (S) 8216302: StackTraceElement::fill_in can use cached Class.name
Aleksey Shipilev
shade at redhat.com
Tue Jan 8 19:56:22 UTC 2019
On 1/8/19 8:47 PM, coleen.phillimore at oracle.com wrote:
>> Thanks for the explanation. So, something like this would do?
>> http://cr.openjdk.java.net/~shade/8216302/webrev.03/
>
> Yes, this looks better. I can't imagine why it would be measurably slower, but beats faster with
> low frequency bugs.
Right. I think dealing with handles has non-zero cost. Targeted benchmarks are really sensitive to
most costs. Pushed the patch to jdk-submit.
> http://cr.openjdk.java.net/~shade/8216302/webrev.03/test/hotspot/jtreg/runtime/StackTrace/StackTraceClassCache.java.html
>
> I have heard that the copyright should also have the Oracle line on it.
There are plenty of Red Hat-added files with only Red Hat copyrights; this is the guidance I
remember having. StackTraceClassCache follows it.
-Aleksey
More information about the hotspot-dev
mailing list