RFR (also tedious) 8216167: Update include guards to reflect correct directories
Kim Barrett
kim.barrett at oracle.com
Thu Jan 10 20:41:03 UTC 2019
> On Jan 10, 2019, at 7:34 AM, coleen.phillimore at oracle.com wrote:
>
>
> No takers? This fixes the include guard to match the file name in 1540 header files.
>
> If you add a header file, please use the file name after src/hotspot as the include guard name from now on (exclude the VM that used to be there).
>
> http://cr.openjdk.java.net/~coleenp/8216167.01.diff.02
This deals with my issue (from the #pragma once thread) about the share/include files by excluding them from the changes.
The pre-existing guard name for share/include/cds.h might not be good, but that’s not a problem with this change.
This has also dealt with the incorrect changes to globalDefinitions_arm.hpp that I previously mentioned.
Looks like Erik has done a good job of checking your patch. I don’t have anything to add to that. Looks good to me.
More information about the hotspot-dev
mailing list