RFR (S) 8216308: StackTraceElement::fill_in can use injected Class source-file

[Aleksey Shipilev]

On 1/12/19 1:43 AM, David Holmes wrote:
>>> I'm also very unclear about how the redefinition case is currently handled. It seems that we will
>>> normally intern NULL (and presumably get a NULL or empty-string oop?) unless ShowHiddenFrames is
>>> set, in which case we use the unknown_class_name() - regardless of whether the frame is actually
>>> hidden or not! This seems broken to me. (Separate bug to fix that is okay if it is indeed broken.)
>>
>> This looks like a bug, but I'm not sure what ShowHiddenFrames is supposed to do here, or how it
>> got there.  I think if Aleksey removed that with this patch it would be fine with me.
> 
> I think use of ShowHiddenFrames here is completely broken. But a seperate bug and some suitable
> archaeology is needed to fix it the right way.

Okay, are we in agreement that current patch does not break anything new? If so, let's push the
current patch in its current form, and then follow up on ShowHiddenFrames in a separate issue. This
would also make current patch simply backportable to 11.

Current patch (no changes since last time):
  http://cr.openjdk.java.net/~shade/8216308/webrev.01/

-Aleksey