RFR (S) 8216308: StackTraceElement::fill_in can use injected Class source-file

Aleksey Shipilev shade at redhat.com
Mon Jan 14 16:23:56 UTC 2019


On 1/14/19 2:49 PM, coleen.phillimore at oracle.com wrote:
>>> Okay I agree it doesn't break anything new though I'd be happier if the
>>> Backtrace::get_line_number issue was fixed. Otherwise it needs a follow up bug too - I'm starting
>>> to think it makes no sense to allow redefinition to occur within a method like this! And this is
>>> a distinct issue from ShowHiddenFrames.
>>
>> There's no practical way to disable redefinition here and it's not something that happens.  You
>> can file a bug for it if you like, but it's not something worth fixing.
> 
> Looking again at the original code.  If you have a redefinition at StringTable::intern() the line
> number from the methodHandle (Method*) is correct.  In this case it's the "old" method.  It's where
> the original method had the exception, which is what you want to print.

+1. I am pushing the change shortly.

-Aleksey




More information about the hotspot-dev mailing list