RFR (S/M): 8213827: NUMA heap allocation does not respect process membind/interleave settings [Was: Re: [PATCH] JDK NUMA Interleaving issue]

sangheon.kim at oracle.com sangheon.kim at oracle.com
Mon Jan 14 20:53:55 UTC 2019


Hi Amith and Thomas,

On 1/14/19 1:34 AM, Thomas Schatzl wrote:
> Hi Amith,
>
> On Sat, 2019-01-12 at 22:57 +0530, amith pawar wrote:
>> Hi Thomas,
>>
>> SPECJBB shows following improvements with latest patch.
>> 1. max-jOPs around 7-9%
>> 2. critical-jOPS around 4-50%
>    thanks!
>
>> In webrev.4, Sangheon suggested following change is missing
>> +      ls.print("UseNUMA is enabled and invoked in '%s' mode."
>> +                " Heap will be configured using NUMA memory nodes:",
>> numa_mode);
>> There is one more space before " Heap.... ", please remove it.
> The space before "Heap" is the space after the full stop in the
> preceding sentence so needed; I moved the space to the previous line
> though.
>
>> Also os_linux.hpp is already updated for new copyright year so patch
>> import fails.
>>
>> The attached patch contains these changes. Please do check.
> Regenerated the v4 webrevs.
V4 webrevs looks good.

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>
>



More information about the hotspot-dev mailing list