RFR (S) 8217378: UseCriticalCMSThreadPriority is broken

Aleksey Shipilev shade at redhat.com
Fri Jan 18 16:58:02 UTC 2019


On 1/18/19 5:33 PM, Daniel D. Daugherty wrote:
> src/hotspot/share/runtime/os.cpp
>     L220:   if ((p >= MinPriority && p <= MaxPriority) ||
>     L221:        (p == CriticalPriority && thread->is_ConcurrentGC_thread())) {
>         nit - please delete one indent space from L221.
> 
>         Copyright year needs to be updated.

Fixed both.

> test/hotspot/jtreg/gc/cms/TestCriticalPriority.java
>     No comments.
> 
> Thumbs up. No need to see another webrev if you fix the nit on L221.

There is the updated webrev anyway:
  http://cr.openjdk.java.net/~shade/8217378/webrev.02/

-Aleksey



More information about the hotspot-dev mailing list