RFR : 8217786: Provide virtualization related info in the hs_error file on linux s390x

[Baesken, Matthias]

> 
> Can't you include this information in an existing section of the error
> processing code instead of adding a new function that is empty
> everywhere except Linux?
>

Hi David ,   do you mean  something like 


#if defined(S390)

  STEP("printing virtualization info")
 ...

#endif

 in   vmError.cpp  ?

I thought about doing this.


 But  on the other hand ,  the now   still  empty   os::pd_print_virtualization_info    in    platforms != linux 
 might fill over time   ( we could  add  [at least for some platforms]   other  virtualization  related  info ).


Best regards, Matthias


> -----Original Message-----
> From: David Holmes <david.holmes at oracle.com>
> Sent: Montag, 28. Januar 2019 12:35
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: Re: RFR : 8217786: Provide virtualization related info in the hs_error
> file on linux s390x
> 
> Hi Matthias,
> 
> On 28/01/2019 6:48 pm, Baesken, Matthias wrote:
> > Hello, please review  this change ; it adds  virtualization related info in the
> hs_error file on linux s390x .
> 
> Can't you include this information in an existing section of the error
> processing code instead of adding a new function that is empty
> everywhere except Linux?
> 
> Thanks,
> David
> 
> > On linux s390x, we usually  (always?)   run in virtualized environments
> (LPAR and/or z/VM / KVM ).
> >
> > It is helpful for instance in support cases to get some information about the
> virtualized environment in the hs_error file .
> > A lot of info can be taken from the /proc/sysinfo file on linux s390x .
> >
> >
> > Bug/webrev :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8217786
> >
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8217786.1/
> >
> >
> >
> > Best regards, Matthias
> >