RFR (S) 8217879: hs_err should print more instructions in hex dump
Aleksey Shipilev
shade at redhat.com
Mon Jan 28 16:48:44 UTC 2019
RFE:
https://bugs.openjdk.java.net/browse/JDK-8217879
Fix:
http://cr.openjdk.java.net/~shade/8217879/webrev.01/
"Instructions" block is useful when following up on hs_errs that happened without the disassembler
attached, which is usually the case coming from users. One can use the disassembler [1] to look
around the code that was crashing, and get extended conjectures why the error happened, including
rewinding a bit of history. However, current window is sometimes too small to infer enough context.
I propose we extend it!
The patch also commons the paths across OS/Arch-specific files to that current "delta" appears less
of the magic number. Plus, it adds cr()-s for consistency across the arches and within the methods.
Testing: eyeballing hs_errs from artificial crashes, Linux x86_64 build, jdk-submit
Thanks,
-Aleksey
[1] I use https://onlinedisassembler.com, for example.
More information about the hotspot-dev
mailing list