RFR (S) 8217879: hs_err should print more instructions in hex dump

Aleksey Shipilev shade at redhat.com
Tue Jan 29 11:36:11 UTC 2019


On 1/29/19 12:21 PM, Stefan Karlsson wrote:
> For this to work as you intend it, max_delta must not be set to page size. If max_delta is set to
> page size, the following would end up with low in Page 0 and high in Page 2:
> 
> +--------+
> | Page 0 |   readable
> +--------+ < 'pc' beginning of Page 1
> | Page 1|   unreadable
> +--------+
> | Page 2 |   readable
> +--------+
> 
> Therefore it seems a bit off to cap with the page size in:
> MIN2(256, min_page_size());
> 
> Given that you use 256 today, this isn't really a problem, but maybe future proof this a bit and use
> min_page_size / 2 to guarantee that either low or high ends up in Page 1?

Right, thanks. To handle that corner case, let's do /2 indeed, updated webrev in-place.

-Aleksey



More information about the hotspot-dev mailing list