RFR (S) 8217879: hs_err should print more instructions in hex dump

[Thomas Stüfe]

On Tue, Jan 29, 2019 at 6:12 PM Aleksey Shipilev <shade at redhat.com> wrote:

> On 1/29/19 5:34 PM, Thomas Stüfe wrote:
> > Even better. No need to store those bytes on the first leg.
>
> This would be webrev.05:
>   http://cr.openjdk.java.net/~shade/8217879/webrev.05/
>
>
Looks fine. You could move calculation of low/high out of the loops though.

If you want to go with this one, I do not need another webrev.


> But I wonder if we should stop this madness and just fix
> os::print_hex_dump, as you suggested earlier:
>   https://bugs.openjdk.java.net/browse/JDK-8217994


Sure this would make sense. I have a half finished version somewhere but I
got carried away and wanted it to work with unaligned pointers/lengths and
all unit sizes and be super fast and look nice and then I forgot about the
whole thing and did something different :P

..Thomas


>
> -Aleksey
>
>
>
>