RFR (S) 8217879: hs_err should print more instructions in hex dump

[Thomas Stüfe]

On Tue, Jan 29, 2019 at 6:33 PM Aleksey Shipilev <shade at redhat.com> wrote:

> On 1/29/19 6:27 PM, Thomas Stüfe wrote:
> > On Tue, Jan 29, 2019 at 6:12 PM Aleksey Shipilev <shade at redhat.com
> <mailto:shade at redhat.com>> wrote:
> >
> >     On 1/29/19 5:34 PM, Thomas Stüfe wrote:
> >     > Even better. No need to store those bytes on the first leg.
> >
> >     This would be webrev.05:
> >       http://cr.openjdk.java.net/~shade/8217879/webrev.05/
> >
> > Looks fine. You could move calculation of low/high out of the loops
> though.
> > If you want to go with this one, I do not need another webrev.
>
> You cannot that easily? Having calculation is the loop guarantees low/high
> are definitely readable.
> You can do this outside the loop, with +1/-1 to delta, but that sets us up
> for the off-by-one errors...
>
>
Oh, okay. This is fine to me then.

..Thomas



> -Aleksey
>
>