RFR : 8217786: Provide virtualization related info in the hs_error file on linux s390x

[Thomas Stüfe]

On Wed, Jan 30, 2019 at 10:00 AM Baesken, Matthias <matthias.baesken at sap.com>
wrote:

> Hi David,
>
> > > Style nit: avoid implicit booleans, explicitly check != NULL
>
> I  added the explicit  "!= NULL" check and  an add a line  with an
> introductory text   .
>
>
> @Thomas  -  may I add you as reviewer  ?
>
>
Yes.

I read up yesterday on /proc/sysinfo and it turns out that is a s390
specific /proc extension? So maybe this whole function should be even more
generalized - maybe take a filename too as input - or just moved to s390
speciifc code.

However, since we put you thru too many iterations already with this patch
I am fine with this version. We can improve it later should we add
virtualization info for other architectures as well.

..Thomas


> Thanks, Matthias
>
>
> > -----Original Message-----
> > From: David Holmes <david.holmes at oracle.com>
> > Sent: Mittwoch, 30. Januar 2019 06:49
> > To: Baesken, Matthias <matthias.baesken at sap.com>; Thomas Stüfe
> > <thomas.stuefe at gmail.com>
> > Cc: hotspot-dev at openjdk.java.net
> > Subject: Re: RFR : 8217786: Provide virtualization related info in the
> hs_error
> > file on linux s390x
> >
> > Hi Matthias,
> >
> > Thanks for reworking this.
> >
> > On 30/01/2019 2:56 am, Baesken, Matthias wrote:
> > > Hello, I added a break to avoid potential printing lines multiple
> times,
> > > and removed the comment line :
> > >
> > > http://cr.openjdk.java.net/~mbaesken/webrevs/8217786.3/
> >
> > A couple of minor comments:
> >
> > src/hotspot/os/linux/os_linux.cpp
> >
> > +     while (keywords_to_match[i]) {
> >
> > Style nit: avoid implicit booleans, explicitly check != NULL
> >
> > + void os::Linux::print_virtualization_info(outputStream* st) {
> >
> > Don't you want an initial print of some introductory text eg:
> >
> > "Virtualization Information"
> >
> > No need for updated webrev.
> >
> > Thanks,
> > David
> > -----
>
>