RFR(s): 8218041: Assorted wrong/missing includes

Aleksey Shipilev shade at redhat.com
Wed Jan 30 10:54:02 UTC 2019


On 1/30/19 9:21 AM, Robbin Ehn wrote:
> Code:
> http://cr.openjdk.java.net/~rehn/8218041/webrev/
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8218041
> 
> After fixing these includes, there was a circular dependency via shenandoah
> code. I moved try_cancel_gc to cpp where the only use was. So it never should
> had been in the inline header in the first place.

I agree with this move. try_cancel is not very performance-sensitive, and it is called when other,
more heavy-weight stuff is happening. I marked the bug with "gc-shenandoah", so we get it in our
backporting queue. Shenandoah still builds fine with/without PCH, and passes tests after this change.

Other changes look good too.

-Aleksey



More information about the hotspot-dev mailing list