RFR (S) 8217994: os::print_hex_dump should be more resilient against unreadable memory

[Schmidt, Lutz]

Aleksey,
I like your revision 02. Very compact.
I do not like re-inventing language features by own code.
Sorry for spamming you with suggestions/comments.
Regards,
Lutz 

On 30.01.19, 13:31, "Aleksey Shipilev" <shade at redhat.com> wrote:

    On 1/30/19 1:10 PM, Thomas Stüfe wrote:
    > Or, since this thing keeps coming up, add a helper to outputStream:
    > 
    > +void outputStream::put(char ch, int repeat_count) {
    > + for (int i = 0; i < repeat_count; i ++) {
    > + put(ch);
    > + }
    > +}
    > +
    > 
    > st->put('?', 2*unitsize);
    
    No. Let's stop here:
     http://cr.openjdk.java.net/~shade/8217994/webrev.02/
    
    There are thousand ways to do things, and there are only 8 work hours per day.
    Current patch with unusual format specifier is already good, to my taste.
    
    -Aleksey