RFR (T): 8218060: JDK-8217786 breaks build due to remaining unused function

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jan 30 15:06:51 UTC 2019


Hi all,

  can I have quick reviews for this change that fixes a compilation
error due to an unused function?

I.e.

Compiling the repo after JDK-8217786 gives the following error: 

.../vmshare/jdk10/hs/open/src/hotspot/os/linux/os_linux.cpp:1860:13:
error: 'bool print_matching_lines_from_sysinfo_file(outputStream*,
const char**)' defined but not used [-Werror=unused-function] 
 static bool print_matching_lines_from_sysinfo_file(outputStream* st,
const char* keywords_to_match[]) { 
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
Compiling 305 files for jdk.javadoc 
cc1plus: all warnings being treated as errors 
make[3]: *** [[...]variant-server/libjvm/objs/os_linux.o] Error 1 
lib/CompileJvm.gmk:172: recipe for target '[...]/linux-
x64/hotspot/variant-server/libjvm/objs/os_linux.o' failed 

The change simply removes that unused function.

CR:
https://bugs.openjdk.java.net/browse/JDK-8218060
Webrev:
http://cr.openjdk.java.net/~tschatzl/8218060/webrev/
Testing:
local compilation

Thanks,
  Thomas




More information about the hotspot-dev mailing list