RFR (S) 8218140: Build failures after JDK-8218041 (Assorted wrong/missing includes)

[Stefan Karlsson]

On 2019-01-31 16:56, Aleksey Shipilev wrote:
> On 1/31/19 4:43 PM, Stefan Karlsson wrote:
>>>> We "recently" removed the orderAccess_<platform>.inline.hpp to allow OrderAcess to be used in
>>>> headers. Maybe it's time to simply move the code above to thread.hpp? That would remove this source
>>>> of compile errors.
>>> I am thinking the reverse: push #ifs around the definition into the method body instead. This would
>>> ensure we use thread.inline.hpp where it makes sense to.
>> Not sure what you mean. Maybe we're saying the same thing. My proposal is this (untested):
>> http://cr.openjdk.java.net/~stefank/8218140/webrev.alt.01/
> Yes, the same thing, but in reverse :) Not a big fan of having non-trivial declarations in the
> header. See the patch here: https://bugs.openjdk.java.net/browse/JDK-8218151
>
> This naturally builds up on having thread.inline.hpp included where needed by this build fix.

Yes, this is cleaner.

StefanK

> -Aleksey
>