RFR: 8226525: HotSpot compile-time error for x86-32

Kim Barrett kim.barrett at oracle.com
Mon Jul 1 17:49:07 UTC 2019


> On Jul 1, 2019, at 10:46 AM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> On 7/1/19 4:22 PM, Andrew Haley wrote:
>> This asm statement:
>> 
>> asm__ volatile ("cpuid " : "+a" (idx) : : "ebx", "ecx", "edx", "memory")
>> 
>> ... breaks on 32-bit systems because the GCC we use doesn't allow EBX to be
>> clobbered. Fixed thusly:
>> 
>> http://cr.openjdk.java.net/~aph/8226525/
> 
> Looks okay to me. Put the comment, e.g.:
>  // EBX is a reserved register on 32-bit Linux systems, cannot clobber it.
> 
> -Aleksey

Looks good.  +1 on the additional comment.



More information about the hotspot-dev mailing list