RFR: 8226238: Improve error output and fix elf issues in os::dll_load

[Doerr, Martin]

Hi Matthias,

thanks for contributing this improvement.

Please note that there are endianness macros available. You can use e.g.
if (elf_head.e_ident[EI_DATA] != LITTLE_ENDIAN_ONLY(ELFDATA2LSB) BIG_ENDIAN_ONLY(ELFDATA2MSB)) {
I don't see why we need a variable "current_endianness".

Besides this, change looks good to me. I don't need to see another webrev.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Baesken, Matthias
> Sent: Freitag, 28. Juni 2019 09:06
> To: Langer, Christoph <christoph.langer at sap.com>; 'hotspot-
> dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR: 8226238: Improve error output and fix elf issues in
> os::dll_load
> 
> Hi Christoph,   thanks for looking into it.
> I  did the changes you  mentioned,  here is my new webrev  :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8226238.4/
> 
> Would be good to get a second review .
> 
> 
> Thanks and best regards, Matthias
> 
> 
> > -----Original Message-----
> > From: Langer, Christoph
> > Sent: Donnerstag, 27. Juni 2019 16:59
> > To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> > dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > Subject: RE: RFR: 8226238: Improve error output and fix elf issues in
> > os::dll_load
> >
> > Hi Matthias,
> >
> > your change looks good overall.
> >
> > I only have a few style nits:
> >
> > src/hotspot/os/linux/os_linux.cpp, line 1751 (new):
> >
> > Can you convert
> >
> > unsigned char current_endianness = ELFDATA2MSB; // BE
> > #if defined(VM_LITTLE_ENDIAN)
> >   current_endianness = ELFDATA2LSB; // LE
> > #endif
> >
> > to
> >
> > #if defined(VM_LITTLE_ENDIAN)
> >   unsigned char current_endianness = ELFDATA2LSB; // LE
> > #else
> >   unsigned char current_endianness = ELFDATA2MSB; // BE
> > #endif
> >
> > And the same in line 1611 of src/hotspot/os/solaris/os_solaris.cpp.
> >
> > src/hotspot/os/linux/os_linux.cpp, line 1802: you could fix the indentation
> of
> > ELFDATA2LSB for EM_ARM
> > same for line 1580 of src/hotspot/os/solaris/os_solaris.cpp.
> >