RFR: 8226238: Improve error output and fix elf issues in os::dll_load

[Doerr, Martin]

Looks good.

Thanks,
Martin

> -----Original Message-----
> From: Baesken, Matthias
> Sent: Dienstag, 2. Juli 2019 14:55
> To: Doerr, Martin <martin.doerr at sap.com>; Langer, Christoph
> <christoph.langer at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-
> dev at openjdk.java.net>
> Subject: RE: RFR: 8226238: Improve error output and fix elf issues in
> os::dll_load
> 
> Hi Martin , thanks for the review .
> 
> I followed your advice and removed the current_endianness   - variable .
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8226238.5/
> 
> 
> Best regards , Matthias
> 
> 
> 
> > Hi Matthias,
> >
> > thanks for contributing this improvement.
> >
> > Please note that there are endianness macros available. You can use e.g.
> > if (elf_head.e_ident[EI_DATA] != LITTLE_ENDIAN_ONLY(ELFDATA2LSB)
> > BIG_ENDIAN_ONLY(ELFDATA2MSB)) {
> > I don't see why we need a variable "current_endianness".
> >
> > Besides this, change looks good to me. I don't need to see another webrev.
> >
> > Best regards,
> > Martin
> >