RFR[13]: 8224531: SEGV while collecting Klass statistics

[Erik Österlund]

Hi Thomas,

Thanks for the review.

On 2019-07-03 21:31, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2019-07-03 at 08:10 -0400, coleen.phillimore at oracle.com wrote:
> http://cr.openjdk.java.net/~eosterlund/8224531/webrev.00/src/hotspot/share/memory/heapInspection.cpp.frames.html
>> There's another object_iterate() in this file with a comment to
>> change it to safe_object_iterate().  Should you change that too?
> I think this is a different issue as Erik pointed out, this is
> iteration during a safepoint. Not that I think that this is much safer
> *and* there is already the comment there that this might not work with
> CMS either.
> Erik, can you file a CR?

Sure, can do.

Thanks,
/Erik

>> Did you run the jvmti tests?  There used to be tests that failed if
>> dead objects weren't found, but the tests may have been fixed.
> It would be nice to at least know which jvmti tests iterate over dead
> objects before pushing this if possible.
>
>> The rest of the change looks good.  Thank you for figuring this out!
> Change looks good.
>
> Thanks,
>    Thomas
>
>