RFR: 8226816: add UserHandler calls to event log

[David Holmes]

Hi Matthias,

On 5/07/2019 10:21 pm, Baesken, Matthias wrote:
> Hello David , here is another webrev  with  get_signal_name / get_signal_number   moved to os.cpp :
> 
> http://cr.openjdk.java.net/~mbaesken/webrevs/8226816.1/

That looks good - thanks. I'm running it through our test system.

One query, in os.cpp:

+ #ifdef _WINDOWS
+   {  SIGBREAK,    "SIGBREAK" },

Can that be

  #ifdef SIGBREAK
    {  SIGBREAK,    "SIGBREAK" },

like the other cases?

No need for an updated webrev if so.

Thanks,
David
-----

> 
> Best regards, Matthias
> 
>>
>> On 4/07/2019 11:06 pm, Baesken, Matthias wrote:
>>> Hi David,  thanks for looking into this .
>>>
>>>>
>>>> If you add this then we don't need distinct POSIX and non-POSIX versions
>>>> - the existing os::Posix::get_signal_name etc could all be hoisted into
>>>> os.cpp and the os class - no?
>>>>
>>>
>>> Should I go for this ?
>>> The coding is still a little different   (e.g. is_valid_signal (.. ) call  in os_posix )
>> but I think it could be done without much trouble (maybe with a few small
>> ifdefs ) .
>>
>> I think it's worth trying it.
>>
>> I have to apologize in advance though as I'm about to disappear on two
>> weeks vacation so may not be able to follow through on this.
>>
>> Thanks,
>> David
>>
>