RFR: 8227631: Adjust AIX version check

[Lindenmaier, Goetz]

Hi Mathias,

... lost the list, sorry.

The change looks good!

Best regards,
  Goetz.

> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Dienstag, 16. Juli 2019 12:59
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Subject: RE: RFR: 8227631: Adjust AIX version check
> 
> Hi Matthias,
> 
> looks fine, thanks a lot!
> 
> Best regards,
>   Goetz.
> 
> > -----Original Message-----
> > From: Baesken, Matthias
> > Sent: Dienstag, 16. Juli 2019 12:18
> > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> > Subject: RE: RFR: 8227631: Adjust AIX version check
> >
> > Hi Goetz  , yes I adjusted this to  "const char *"  and do not see the warning
> any
> > more  ,  new webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8227631.1/
> >
> >
> > Best regards, Matthias
> >
> >
> > > -----Original Message-----
> > > From: Lindenmaier, Goetz
> > > Sent: Dienstag, 16. Juli 2019 11:16
> > > To: Baesken, Matthias <matthias.baesken at sap.com>
> > > Subject: RE: RFR: 8227631: Adjust AIX version check
> > >
> > > I think
> > >   const char *name_str
> > > should do the job.
> > >
> > > Best regards,
> > >   Goetz.
> > >
> > > > -----Original Message-----
> > > > From: Baesken, Matthias
> > > > Sent: Dienstag, 16. Juli 2019 09:52
> > > > To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Doerr, Martin
> > > > <martin.doerr at sap.com>
> > > > Cc: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>
> > > > Subject: RE: RFR: 8227631: Adjust AIX version check
> > > >
> > > > > would print the OS, too, as it did before.
> > > >
> > > > Hi Goetz  I do not think that we currently run  in OpenJDK  on OS/400 ,
> > > >   so printing the OS does not have much value currently ( it is always AIX) .
> > > >
> > > > > Didn't the warning stem from the
> > > > >   assert(false, name_str);
> > > >
> > > > I think clang does not like  the usage  of   string literals  for non-constant
> > > strings
> > > > [-Wwritable-strings]  .
> > > >
> > > > Best regards, Matthias
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Lindenmaier, Goetz
> > > > > Sent: Dienstag, 16. Juli 2019 09:30
> > > > > To: Baesken, Matthias <matthias.baesken at sap.com>; Doerr, Martin
> > > > > <martin.doerr at sap.com>
> > > > > Subject: RE: RFR: 8227631: Adjust AIX version check
> > > > >
> > > > > Hi Matthias,
> > > > >
> > > > > limiting the version is a good idea.
> > > > >
> > > > > As this is only a trace and an assertion (debug build),
> > > > > I don't think it is necessary to push it to 13, but
> > > > > pushing it there is fine too.
> > > > >
> > > > > I would appreciate if the
> > > > >   trcVerbose("We run on %s %s", name_str, ver_str);
> > > > > would print the OS, too, as it did before.
> > > > > As the code for OS/400 is in there, also the tracing
> > > > > should be complete.
> > > > >
> > > > > Didn't the warning stem from the
> > > > >   assert(false, name_str);
> > > > > which correctly could be
> > > > >   assert(false, "%s", name_str);
> > > > > ?  (Your version for the assert is fine, too.)
> > > > >
> > > > > Best regards,
> > > > >   Goetz.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Langer, Christoph
> > > > > > Sent: Freitag, 12. Juli 2019 14:17
> > > > > > To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-
> > > > > > dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>; 'ppc-aix-
> > > port-
> > > > > > dev at openjdk.java.net' <ppc-aix-port-dev at openjdk.java.net>
> > > > > > Subject: RE: RFR: 8227631: Adjust AIX version check
> > > > > >
> > > > > > Hi Matthias,
> > > > > >
> > > > > > looks good. This might even be something to push to JDK13 still (if you
> > > do it
> > > > > > within the next few days).
> > > > > >
> > > > > > Best regards
> > > > > > Christoph
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On
> > > Behalf
> > > > > Of
> > > > > > > Baesken, Matthias
> > > > > > > Sent: Freitag, 12. Juli 2019 13:09
> > > > > > > To: 'hotspot-dev at openjdk.java.net' <hotspot-
> > > dev at openjdk.java.net>;
> > > > > > > 'ppc-aix-port-dev at openjdk.java.net' <ppc-aix-port-
> > > > > dev at openjdk.java.net>
> > > > > > > Subject: RFR: 8227631: Adjust AIX version check
> > > > > > >
> > > > > > > Hello, please review this small AIX related change .
> > > > > > >
> > > > > > > For some time, we do not support AIX 5.3 any more.
> > > > > > > See (where AIX 7.1 or 7.2 is the supported build platform since
> > > > > OpenJDK11) :
> > > > > > >
> > > > > > >
> > > https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
> > > > > > >
> > > > > > > The currently used xlc 16.1 (XL C/C++ Compilers) even  needs
> > > minimum
> > > > > AIX
> > > > > > > 7.1 to  run , see
> > > > > > >
> > > > > > > http://www-01.ibm.com/support/docview.wss?uid=swg21326972
> > > > > > >
> > > > > > > (and compiling for older releases on 7.1 / 7.2 would not work easily ,
> > > at
> > > > > least
> > > > > > > not "out of the box"  to my knowledge .)
> > > > > > >
> > > > > > > So we should adjust the minimum OS version check done in
> > > os_aix.cpp in
> > > > > > > os::Aix::initialize_os_info() .
> > > > > > >
> > > > > > >
> > > > > > > Additionally the change removes a couple of warnings   [-Wwritable-
> > > > > strings
> > > > > > > category]  .
> > > > > > >
> > > > > > > /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4081:22: warning: ISO
> > > C++11
> > > > > > > does not allow conversion from string literal to 'char *' [-Wwritable-
> > > > > strings]
> > > > > > >     char *name_str = "unknown OS";
> > > > > > >                      ^
> > > > > > > /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4089:18: warning: ISO
> > > C++11
> > > > > > > does not allow conversion from string literal to 'char *' [-Wwritable-
> > > > > strings]
> > > > > > >       name_str = "OS/400 (pase)";
> > > > > > >                  ^
> > > > > > > /nightly/jdk/src/hotspot/os/aix/os_aix.cpp:4100:18: warning: ISO
> > > C++11
> > > > > > > does not allow conversion from string literal to 'char *' [-Wwritable-
> > > > > strings]
> > > > > > >       name_str = "AIX";
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > Bug/webrev :
> > > > > > >
> > > > > > > https://bugs.openjdk.java.net/browse/JDK-8227631
> > > > > > >
> > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8227631.0/
> > > > > > >
> > > > > > > Thanks, Matthias