RFR (S) 8227123: Assertion failure when setting SymbolTableSize larger than 2^17 (131,072)

[David Holmes]

Hi Coleen,

-  experimental(bool, UnlockExperimentalVMOptions, false, 
     \
+  experimental(bool, UnlockExperimentalVMOptions, trueInDebug, 
     \

I can't quite convince myself this is harmless nor necessary.

Functional change seems fine. Is it worth adding a clarifying comment to:

+          range(minimumSymbolTableSize, 16777216ul) 
     \

with:

+          range(minimumSymbolTableSize, 16777216ul /* 2^24 */) 
                \

Thanks,
David

On 23/07/2019 4:45 am, coleen.phillimore at oracle.com wrote:
> Summary: Increase max size for SymbolTable and fix experimental option 
> range.  Make experimental options trueInDebug so they're tested by the 
> command line option testing
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8227123.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8227123
> 
> Tested locally with default and -XX:+UseZGC since ZGC has a lot of 
> experimental options.  I didn't test with shenanodoah.
> 
> I will test with hs-tier1-3 before checking in.
> 
> Thanks,
> Coleen