[14] RFR(XS): 8071275: remove AbstractAssembler::update_delayed_values dead code

Doerr, Martin martin.doerr at sap.com
Wed Jul 24 12:16:42 UTC 2019


Hi Christian,

please also remove check_method_handle_type from macroAssembler_ppc.hpp:
diff -r 4c1fc3947383 src/hotspot/cpu/ppc/macroAssembler_ppc.hpp
--- a/src/hotspot/cpu/ppc/macroAssembler_ppc.hpp        Wed Jul 24 14:06:44 2019 +0200
+++ b/src/hotspot/cpu/ppc/macroAssembler_ppc.hpp        Wed Jul 24 14:13:27 2019 +0200
@@ -565,8 +565,6 @@
                       Label* L_slow_path = NULL);

   // Method handle support (JSR 292).
-  void check_method_handle_type(Register mtype_reg, Register mh_reg, Register temp_reg, Label& wrong_method_type);
-
   RegisterOrConstant argument_offset(RegisterOrConstant arg_slot, Register temp_reg, int extra_slot_offset = 0);

   // Biased locking support

Looks good otherwise. I don't need to see another webrev for that. Thanks for cleaning this up.

Best regards,
Martin


> -----Original Message-----
> From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
> Tobias Hartmann
> Sent: Mittwoch, 24. Juli 2019 14:04
> To: Christian Hagedorn <christian.hagedorn at oracle.com>; hotspot-
> dev at openjdk.java.net
> Subject: Re: [14] RFR(XS): 8071275: remove
> AbstractAssembler::update_delayed_values dead code
> 
> Hi Christian,
> 
> looks good to me.
> 
> Best regards,
> Tobias
> 
> On 24.07.19 13:57, Christian Hagedorn wrote:
> > Hi
> >
> > Please review the following enhancement:
> > https://bugs.openjdk.java.net/browse/JDK-8071275
> > http://cr.openjdk.java.net/~thartmann/8071275/webrev.00/
> >
> > This just removes some dead code.
> >
> > Thanks!
> >
> > Best regards,
> > Christian


More information about the hotspot-dev mailing list