[14] RFR(XS): 8156207 : Resource allocated BitMaps are often cleared unnecessarily
Kim Barrett
kim.barrett at oracle.com
Sat Jul 27 23:42:33 UTC 2019
> On Jul 26, 2019, at 8:23 AM, Christian Hagedorn <christian.hagedorn at oracle.com> wrote:
>
> Hi
>
> Please review the following patch:
> http://cr.openjdk.java.net/~thartmann/8156207/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8156207
>
> This is just a completion of the suggested change in the comments.
>
> Thank you!
>
> Best regards,
> Christian
------------------------------------------------------------------------------
src/hotspot/share/utilities/bitMap.hpp
332 // Clears the bitmap memory.
333 ResourceBitMap(idx_t size_in_bits, bool clear = true);
The comment should be updated to indicate the clearing is conditional.
------------------------------------------------------------------------------
Otherwise, looks good. I don't need a new webrev for a fix of that
comment.
While reviewing this change I noticed JDK-8228692.
More information about the hotspot-dev
mailing list