RFR (S) 8227123: Assertion failure when setting SymbolTableSize larger than 2^17 (131,072)

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Jul 29 14:56:34 UTC 2019



On 7/26/19 10:47 AM, gerard ziemski wrote:
> Thank you for fixing this!
>
> Just a small nick pick - this comment in symbolTable.cpp:
>
> +// 2^24 is max size, like StringTable.
>
> doesn't particularly strike me as all that useful.

Thanks Gerard.  I don't see why it should be different.  Most Strings 
come to the JVM as Symbol's first, ie. JVM_CONSTANT_Utf8, so it seems 
that the tables should have the same limits.

Thank you for the code review.
Coleen
>
> cheers
>
>
>
> On 7/25/19 4:53 PM, coleen.phillimore at oracle.com wrote:
>>
>> After some offline polling of various people, I'm going to withdraw 
>> the UnlockExperimentalOptions change to trueInDebug, and fixed the 
>> options test.
>>
>> http://cr.openjdk.java.net/~coleenp/2019/8227123.02/webrev/index.html
>>
>> These test changes would have found the original bug.
>>
>> Thanks,
>> Coleen
>



More information about the hotspot-dev mailing list