[14] RFR(S): 8193042: NativeLookup::lookup_critical_entry() should only load shared library once

David Holmes david.holmes at oracle.com
Mon Jul 29 22:56:10 UTC 2019


Hi Christian,

Thanks for fixing this one - not sure why it was filed as a compiler bug 
rather than runtime :)

On 29/07/2019 11:27 pm, Christian Hagedorn wrote:
> Hi
> 
> Please review the following enhancement:
> http://cr.openjdk.java.net/~thartmann/8193042/webrev.00/

Changes look good.

There are a few inherited style nits (missing braces on if-blocks) but 
not worth pointing out as that code contains a lot of them.

What testing did you do for this? (I'm not sure which tests would 
exercise this code.)

Thanks,
David

> https://bugs.openjdk.java.net/browse/JDK-8193042
> 
> This avoids repeated loads/unloads of the same shared library.
> 
> Thanks!
> 
> Best regards,
> Christian


More information about the hotspot-dev mailing list