RFR (T) 8228855: Test runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails after JDK-8227123

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Jul 31 13:39:55 UTC 2019



On 7/31/19 9:25 AM, coleen.phillimore at oracle.com wrote:
>
>
> On 7/31/19 9:12 AM, David Holmes wrote:
>> I haven't seen Coleen's original mail turn up yet, so I'll respond here.

I haven't gotten the email yet either.
>>
>> Shouldn't the range be handled by the constraint function:
>
> It is not handled that way in ObjAlignmentInBytes.

What I meant is that ObjectAlignmentInBytes has the constraint function 
AND the range.  SurvivorAlignmentInBytes should be the same.  The 
constraint function tests that it's > ObjectAlignmentInBytes.

  158   lp64_product(intx, ObjectAlignmentInBytes, 8,                             \
  159           "Default object alignment in bytes, 8 is minimum")                \
  160           range(8, 256)                                                     \
  161           constraint(ObjectAlignmentInBytesConstraintFunc,AtParse)          \


Coleen
>
> Coleen
>>
>>  SurvivorAlignmentInBytesConstraintFunc
>>
>> ?
>>
>> David (signing off for the night)
>>
>> On 31/07/2019 11:04 pm, Aleksey Shipilev wrote:
>>> On 7/31/19 2:56 PM, coleen.phillimore at oracle.com wrote:
>>>> open webrev at 
>>>> http://cr.openjdk.java.net/~coleenp/2019/8228855.01/webrev
>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8228855
>>>
>>> Looks good and trivial.
>>>
>



More information about the hotspot-dev mailing list