RFR (XXS) 8228907: Some gc argument checking tests fail after JDK-8228855

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Jul 31 20:41:34 UTC 2019


On 7/31/19 4:01 PM, coleen.phillimore at oracle.com wrote:
> Summary: Use new SurvivorAlignmentInBytes range in tests, remove test 
> cases that verify unnecessarily large values.
>
> Tested locally with:
>
> make test TEST=gc/arguments
>
> Will wait for hs-tier1-3 to finish before pushing after reviewed.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8228907.01/webrev

test/hotspot/jtreg/gc/arguments/TestSurvivorAlignmentInBytesOption.java
     No comments.

test/hotspot/jtreg/gc/survivorAlignment/TestPromotionLABLargeSurvivorAlignment.java
     Your comment in the bug says this:

     > One test is testing 1k, 16k, etc, which seems extreme.

     but you also took out this test case:

     > -XX:SurvivorAlignmentInBytes=512

     so your largest test case is now:

     > -XX:SurvivorAlignmentInBytes=256

     You might want to update the bug report to match this fix.

Thumbs up (modulo hs-tier[1-3] testing.

Dan


> bug link https://bugs.openjdk.java.net/browse/JDK-8228907
>
> Thanks,
> Coleen



More information about the hotspot-dev mailing list