RFR (XXS) 8228907: Some gc argument checking tests fail after JDK-8228855

Kim Barrett kim.barrett at oracle.com
Wed Jul 31 21:56:40 UTC 2019


> On Jul 31, 2019, at 5:41 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> On 1/08/2019 6:01 am, coleen.phillimore at oracle.com wrote:
>> Summary: Use new SurvivorAlignmentInBytes range in tests, remove test cases that verify unnecessarily large values.
> 
> As long as the GC team agree they are unnecessarily large the changes seem fine.

If we’re not going to allow values that large (per JDK-8228855), then trying to test them here is pointless.

We do end up with some intertwined dependencies though, and I’m not seeing a good way to deal with that.
The range that makes sense to test here is limited by the valid range for SurvivorAlignmentInBytes.
Maybe have the test take a special “MAX_VALUE” token and ask the VM for the max value?  Do we
have that capability at all right now (perhaps via WhiteBox)?  I don’t recall seeing anything like that,
but might be forgetting.

Even if we want to do something like that, I think it should be done as a followup.  For now, getting this
failure out of testing seems more urgent than improving the test.

> 
> Thanks,
> David
> 
>> Tested locally with:
>> make test TEST=gc/arguments
>> Will wait for hs-tier1-3 to finish before pushing after reviewed.
>> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8228907.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8228907
>> Thanks,
>> Coleen




More information about the hotspot-dev mailing list