RFR [XXS] JDK 13 of JDK-8164819: Make javac's toString() on annotation objects consistent with core reflection

Joe Darcy joe.darcy at oracle.com
Tue Jun 4 16:56:46 UTC 2019


Hello,

In the course of working on the fix for

         JDK-8164819: Make javac's toString() on annotation objects 
consistent with core reflection

which updates the core reflection toString output of annotations, one 
HotSpot test relies on the old format. This RFR is for the needed update 
to the HotSpot test. The rest of the fix has been out for review on 
core-libs and compiler-dev:

https://mail.openjdk.java.net/pipermail/compiler-dev/2019-June/013427.html
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-June/060592.html

The latest webrev

     http://cr.openjdk.java.net/~darcy/8164819.3/

updates test/hotspot/jtreg/runtime/8007320/ConstMethodTest.java to use 
the new format:

@@ -120,12 +120,12 @@
              if (m.getName().equals("kitchenSinkFunc")) {
                  Annotation[][] ann = m.getParameterAnnotations();
                  equal(ann.length, 3);
                  Annotation foo = ann[0][0];
                  Annotation bar = ann[1][0];
-                equal(foo.toString(), "@Named(value=\"aName\")");
-                equal(bar.toString(), "@Named(value=\"bName\")");
+                equal(foo.toString(), "@Named(\"aName\")");
+                equal(bar.toString(), "@Named(\"bName\")");
                  check(foo.equals(foo));
                  check(bar.equals(bar));
                  check(! foo.equals(bar));
                  // method annotations
                  Annotation[] ann2 = m.getAnnotations();

Thanks,

-Joe



More information about the hotspot-dev mailing list