RFR: 8225429: Regression in disassembly quality

[John Rose]

On Jun 6, 2019, at 10:56 AM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
> 
> I didn't see the original review for the disassembly change but even in product you used to get most of this information.  Assembler comment capturing is a non-product feature unfortunately, so those were never available.  Was it intentional to turn all this output off in product? I'd rather see it restored even in product myself.

Effective diagnosis and performance tuning requires accurate,
informative disassembly.  I would support moving the assembler
comment capture, whenever disassembly is enabled.  If there's
a risk of disturbing program dynamics with the extra footprint,
perhaps it could be broken out as a separate diagnostic option.

More disassembly information is better, even in product mode!

— John