RFR: 8225429: Regression in disassembly quality

[Andrew Haley]

On 6/7/19 5:52 PM, Tom Rodriguez wrote:
> 
> Andrew Haley wrote on 6/7/19 1:18 AM:
>> On 6/6/19 9:22 PM, John Rose wrote:
>>> On Jun 6, 2019, at 10:56 AM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>>>
>>> Effective diagnosis and performance tuning requires accurate,
>>> informative disassembly.  I would support moving the assembler
>>> comment capture, whenever disassembly is enabled.  If there's
>>> a risk of disturbing program dynamics with the extra footprint,
>>> perhaps it could be broken out as a separate diagnostic option.
>>>
>>> More disassembly information is better, even in product mode!
>>
>> OK. I can do that later, but I'd like this patch (which fixes the
>> regression) in now.
> 
> I think your current patch is good given how broken it currently is.  So 
> I approve of your current patch, though I would like to see your new 
> defaults abstractDisassembler.cpp apply product as well so it always 
> looks the same as it used to.

OK, I'll have a look at what product did.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671