RFR(T) : 8209917 : fix TODO in GatherDiagnosticInfoObserver

David Holmes david.holmes at oracle.com
Mon Jun 10 23:19:45 UTC 2019


Hi Igor,

It may be marginally more efficient to replace the pattern:

xxxJdk = Paths.get(rp.getXXXJDK().getAbsolutePath());

with

xxxJdk = rp.getXXXJDK().getAbsoluteFile().toPath();

to avoid switching to/from string representations.

Thanks,
David

On 11/06/2019 7:18 am, Igor Ignatyev wrote:
> ping.
> 
>> On Jun 5, 2019, at 6:46 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~iignatyev//8209917/webrev.00/index.html
>>> 11 lines changed: 0 ins; 3 del; 8 mod;
>>
>> Hi all,
>>
>> could you please review this small and trivial clean up in failure_handler library?
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8209917/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8209917
>> testing: make test TEST=failure-handler; tier1
>>
>> Thanks,
>> -- Igor
> 


More information about the hotspot-dev mailing list