RFR(T) : 8209917 : fix TODO in GatherDiagnosticInfoObserver

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jun 11 00:08:31 UTC 2019


Hi Jon,

thanks a lot for reviewing this! I've also got a review from David H.

-- Igor

> On Jun 10, 2019, at 4:27 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> OK from the jtreg perspective, but I don't normally review Hotspot files, and so I should not be the only Reviewer on the changeset.
> 
> -- Jon
> 
> 
> On 06/10/2019 02:18 PM, Igor Ignatyev wrote:
>> ping.
>> 
>>> On Jun 5, 2019, at 6:46 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 
>>> http://cr.openjdk.java.net/~iignatyev//8209917/webrev.00/index.html
>>>> 11 lines changed: 0 ins; 3 del; 8 mod;
>>> Hi all,
>>> 
>>> could you please review this small and trivial clean up in failure_handler library?
>>> 
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8209917/webrev.00/index.html
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8209917
>>> testing: make test TEST=failure-handler; tier1
>>> 
>>> Thanks,
>>> -- Igor
> 



More information about the hotspot-dev mailing list