PING: RFR(s): 8224600: Provide VM.events command

[Thomas Stüfe]

Thanks Yumin!

On Tue, Jun 11, 2019, 19:51 yumin qi <yumin.qi at gmail.com> wrote:

> HI, Thomas
>
>   Sorry for late reply, It looks good to me.
>
> Thanks
> Yumin
>
> On Tue, Jun 4, 2019 at 1:04 AM Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
>
>> Thank you Christoph!
>>
>> I'll give Yumin time for feedback then will push later today or tomorrow.
>>
>> Cheers, Thomas
>>
>> On Tue, Jun 4, 2019 at 9:49 AM Langer, Christoph <
>> christoph.langer at sap.com>
>> wrote:
>>
>> > Hi Thomas,
>> >
>> > I had a look at your patch and it looks good to me.
>> >
>> > One minor thing: copyright year in diagnosticCommand.cpp.
>> >
>> > Also, the bug is https://bugs.openjdk.java.net/browse/JDK-8224600,
>> > JDK-8224601 is the CSR ��
>> >
>> > Best regards
>> > Christoph
>> >
>> > > -----Original Message-----
>> > > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
>> > > Thomas Stüfe
>> > > Sent: Montag, 3. Juni 2019 10:20
>> > > To: HotSpot Open Source Developers <hotspot-dev at openjdk.java.net>
>> > > Subject: PING: RFR(s): 8224600: Provide VM.events command
>> > >
>> > > Hi all,
>> > >
>> > > may I please have a second reviewer for this. It is a rather small
>> > addition
>> > > to add a new jcmd to print event logs.
>> > >
>> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224601
>> > > Latest webrev:
>> > > http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.01/webrev
>> > > /
>> > >
>> > > Thank you, Thomas
>> > >
>> > > On Thu, May 23, 2019 at 9:51 PM Thomas Stüfe <thomas.stuefe at gmail.com
>> >
>> > > wrote:
>> > >
>> > > > Hi all,
>> > > >
>> > > > May I please have reviews for the following addition to jcmd.
>> > > >
>> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8224600
>> > > > CSR: https://bugs.openjdk.java.net/browse/JDK-8224601
>> > > > webrev:
>> > > >
>> > > http://cr.openjdk.java.net/~stuefe/webrevs/vm.events/webrev.00/webrev
>> > > /index.html
>> > > >
>> > > > This adds a new command, "VM.events", which can be used to display
>> VM
>> > > > event logs. Please see linked CSR for details.
>> > > >
>> > > > The CSR itself is not yet approved but already in proposed state.
>> > > >
>> > > > Thanks, Thomas
>> > > >
>> >
>>
>