RFR: 8225779: Remove unused CollectedHeap::cell_header_size()

Roman Kennke rkennke at redhat.com
Fri Jun 14 09:15:26 UTC 2019


Looks good to me.

If we are into cleaning up unused interfaces, there are more candidates:
- CH::obj_size() is not needed anymore for the same reason as cell_size()
- All object equals is not needed anymore, and hard to maintain if not used by an actual GC
- The allocation paths, even though I'd tend to keep it for the GC-owns-it-all paradigm
- The primitive barrier stuff, even though I'd tend to keep it for the GC-owns-it-all paradigm

I probably missed some too ;-)

Cheers, Roman


Am 14. Juni 2019 08:29:06 MESZ schrieb Per Liden <per.liden at oracle.com>:
>CollectedHeap::cell_header_size() is no longer used and can be removed.
>
>This patch is a hg backout of [1] where it was introduced, plus the two
>
>followup bug fixes [2] & [3].
>
>This is a clean backout, with the exception of light editing needed in 
>two places, because:
>
>1) The function Universe::narrow_oop_base() has since been renamed to 
>CompressedOops::base().
>2) The include guard CPU_ARM_VM_MACROASSEMBLER_ARM_HPP has since been 
>renamed to CPU_ARM_MACROASSEMBLER_ARM_HPP.
>
>Testing: Tier1-3 on all Oracle platforms
>
>Bug: https://bugs.openjdk.java.net/browse/JDK-8225779
>Webrev: http://cr.openjdk.java.net/~pliden/8225779/webrev.0
>
>/Per
>
>[1] http://hg.openjdk.java.net/jdk/jdk/rev/4ad404da0088
>[2] http://hg.openjdk.java.net/jdk/jdk/rev/f642ede2eb07
>[3] http://hg.openjdk.java.net/jdk/jdk/rev/18bd95c0e463

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


More information about the hotspot-dev mailing list