RFR(trivial): JDK-8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278

Ao Qi aoqi at loongson.cn
Thu Jun 27 10:13:07 UTC 2019


On Thu, Jun 27, 2019 at 5:53 PM Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 6/27/19 11:49 AM, Ao Qi wrote:
> > JBS:
> > https://bugs.openjdk.java.net/browse/JDK-8226871
> >
> > Fix:
> > http://cr.openjdk.java.net/~aoqi/8226871/webrev.00/
>
> I don't think we should be adding .inline.hpp includes into .hpp files. From the failure log in the
> bug, it seems we'd need to add that include to stubRoutines.cpp instead?

Yes. You are right. Updated: http://cr.openjdk.java.net/~aoqi/8226871/webrev.01/

Tested: server/minimal build, and hotspot:tier1.

Thanks,
Ao Qi

>
> -Aleksey
>


More information about the hotspot-dev mailing list