RFR: JDK-8226878: zero crashes after JDK-8191278

[Aleksey Shipilev]

On 6/28/19 2:56 AM, Ao Qi wrote:
>> Hold on. I think stubGenerator_zero.cpp should just return NULL when stub is not generated. It looks
>> like a Zero-specific problem to return "fake" stubs when they are not actually generated. Like this:
>>
>> diff -r 91b38bfb9079 src/hotspot/cpu/zero/stubGenerator_zero.cpp
>> --- a/src/hotspot/cpu/zero/stubGenerator_zero.cpp       Thu Jun 27 18:00:54 2019 +0800
>> +++ b/src/hotspot/cpu/zero/stubGenerator_zero.cpp       Thu Jun 27 13:37:47 2019 +0200
>> @@ -157,7 +157,9 @@
>>
>>      StubRoutines::_checkcast_arraycopy       = ShouldNotCallThisStub();
>> -    StubRoutines::_unsafe_arraycopy          = ShouldNotCallThisStub();
>>      StubRoutines::_generic_arraycopy         = ShouldNotCallThisStub();
>>
>> +    // Shared code tests for "NULL" to discover the stub is not generated.
>> +    StubRoutines::_unsafe_arraycopy          = NULL;
>> +
>>      // We don't generate specialized code for HeapWord-aligned source
>>      // arrays, so just use the code we've already generated
>>
> 
> I'm fine with this fix.

Tad confused here. Are you preparing the updated RFR, or should I?

-- 
Thanks,
-Aleksey