[13]RFR: 8226899: Problemlist compiler/rtm tests

Fri Jun 28 20:26:42 UTC 2019

Hi Christian,

On 06/27/2019 04:19 PM, Christian Tornqvist wrote:
> Please review this small change that adds a few of the compiler/rtm tests to the ProblemList, these tests are consistently failing on Intel Skylake CPUs.
> 
> Webrev:
> http://cr.openjdk.java.net/~ctornqvi/webrev/8226899/webrev.00/ <http://cr.openjdk.java.net/~ctornqvi/webrev/8226899/webrev.00/>
> 
> Bug for the failing tests:
> https://bugs.openjdk.java.net/browse/JDK-8183263 <https://bugs.openjdk.java.net/browse/JDK-8183263>

Are you sure these tests are currently failing on Skylake?

For changes [1, 2], I recently tested the RTM tests and they were passing
consistently both on PPC64 and x86_64. Would bugs JDK-8183263 and
JDK-8180723 be outdated?

I've just retested it on my Skylake and they still look ok too (Please see
the results below with some information about my x86_64 CPU).

Thank you.

Best regards,
Gustavo

[1] https://bugs.openjdk.java.net/browse/JDK-8223660
[2] https://bugs.openjdk.java.net/browse/JDK-8225663

gromero at moog:~/hg/jdk/jdk$ make test JTREG="OPTIONS=-nativepath:/home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/support/test/hotspot/jtreg/native/lib" TEST=./test/hotspot/jtreg/compiler/rtm
Building target 'test' in configuration 'linux-x86_64-server-release'
Skip building of Graal unit tests because 3rd party libraries directory is not specified
Skip building of Graal unit tests because 3rd party libraries directory is not specified
Running tests using JTREG control variable 'OPTIONS=-nativepath:/home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/support/test/hotspot/jtreg/native/lib'
Test selection './test/hotspot/jtreg/compiler/rtm', will run:
* jtreg:./test/hotspot/jtreg/compiler/rtm

Running test 'jtreg:./test/hotspot/jtreg/compiler/rtm'
Passed: compiler/rtm/cli/TestRTMLockingCalculationDelayOption.java
Passed: compiler/rtm/cli/TestRTMLockingThresholdOption.java
Passed: compiler/rtm/cli/TestRTMAbortThresholdOption.java
Passed: compiler/rtm/cli/TestRTMRetryCountOption.java
Passed: compiler/rtm/cli/TestRTMSpinLoopCountOption.java
Passed: compiler/rtm/cli/TestPrintPreciseRTMLockingStatisticsOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMLockingOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMForStackLocksOptionOnSupportedConfig.java
Passed: compiler/rtm/cli/TestUseRTMLockingOptionWithBiasedLocking.java
Passed: compiler/rtm/cli/TestUseRTMXendForLockBusyOption.java
Passed: compiler/rtm/locking/TestRTMAbortRatio.java
Passed: compiler/rtm/locking/TestRTMAbortThreshold.java
Passed: compiler/rtm/locking/TestRTMAfterNonRTMDeopt.java
Passed: compiler/rtm/cli/TestRTMTotalCountIncrRateOptionOnSupportedConfig.java
Passed: compiler/rtm/locking/TestRTMDeoptOnHighAbortRatio.java
Passed: compiler/rtm/locking/TestRTMDeoptOnLowAbortRatio.java
Passed: compiler/rtm/locking/TestRTMLockingThreshold.java
Passed: compiler/rtm/locking/TestRTMLockingCalculationDelay.java
Passed: compiler/rtm/locking/TestUseRTMAfterLockInflation.java
Passed: compiler/rtm/locking/TestRTMTotalCountIncrRate.java
Passed: compiler/rtm/locking/TestUseRTMDeopt.java
Passed: compiler/rtm/locking/TestUseRTMForInflatedLocks.java
Passed: compiler/rtm/locking/TestUseRTMForStackLocks.java
Passed: compiler/rtm/method_options/TestNoRTMLockElidingOption.java
Passed: compiler/rtm/method_options/TestUseRTMLockElidingOption.java
Passed: compiler/rtm/locking/TestRTMSpinLoopCount.java
Passed: compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
Passed: compiler/rtm/locking/TestRTMRetryCount.java
Passed: compiler/rtm/locking/TestUseRTMXendForLockBusy.java
Test results: passed: 30
Report written to /home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/test-results/jtreg_test_hotspot_jtreg_compiler_rtm/html/report.html
Results written to /home/gromero/hg/jdk/jdk/build/linux-x86_64-server-release/test-support/jtreg_test_hotspot_jtreg_compiler_rtm
Finished running test 'jtreg:./test/hotspot/jtreg/compiler/rtm'
Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_hotspot_jtreg_compiler_rtm

==============================
Test summary
==============================
    TEST                                              TOTAL  PASS  FAIL ERROR
    jtreg:./test/hotspot/jtreg/compiler/rtm              30    30     0     0
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-x86_64-server-release'

gromero at moog:~/hg/jdk/jdk$ hg log -vr.
changeset:   55524:b279ae9843b8
tag:         tip
user:        ccheung
date:        Fri Jun 28 09:49:10 2019 -0700
files:       src/hotspot/os/aix/os_aix.inline.hpp src/hotspot/os/bsd/os_bsd.inline.hpp src/hotspot/os/linux/os_linux.inline.hpp src/hotspot/os/posix/os_posix.cpp src/hotspot/os/solaris/os_solaris.inline.hpp src/hotspot/os/windows/os_windows.cpp src/hotspot/os/windows/os_windows.inline.hpp src/hotspot/share/classfile/classLoader.cpp src/hotspot/share/classfile/classLoader.hpp src/hotspot/share/classfile/classLoaderExt.cpp src/hotspot/share/classfile/sharedPathsMiscInfo.cpp src/hotspot/share/memory/filemap.cpp src/hotspot/share/memory/filemap.hpp src/hotspot/share/runtime/arguments.cpp src/hotspot/share/runtime/os.hpp test/hotspot/jtreg/TEST.groups test/hotspot/jtreg/runtime/appcds/AppCDSOptions.java test/hotspot/jtreg/runtime/appcds/AppendClasspath.java test/hotspot/jtreg/runtime/appcds/BootClassPathMismatch.java test/hotspot/jtreg/runtime/appcds/PrintSharedArchiveAndExit.java test/hotspot/jtreg/runtime/appcds/RelativePath.java test/hotspot/jtreg/runtime/appcds/TestCommon.java test/hotspot/jtreg/runtime/appcds/dynamicArchive/DynamicArchiveTestBase.java test/hotspot/jtreg/runtime/appcds/dynamicArchive/RelativePath.java
description:
8211723: AppCDS: referring to a jar file in any way other than exactly how it was done during dumping doesn't work
Summary: Replaced os::file_name_strncmp() with os::same_files().
Reviewed-by: iklam, jiangli

gromero at moog:~/hg/jdk/jdk$ hg path
default = http://hg.openjdk.java.net/jdk/jdk/

gromero at moog:~/hg/jdk/jdk$ uname -a
Linux moog 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
gromero at moog:~/hg/jdk/jdk$ lscpu
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              8
On-line CPU(s) list: 0-7
Thread(s) per core:  2
Core(s) per socket:  4
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               94
Model name:          Intel(R) Xeon(R) CPU E3-1280 v5 @ 3.70GHz
Stepping:            3
CPU MHz:             900.123
CPU max MHz:         4000.0000
CPU min MHz:         800.0000
BogoMIPS:            7392.00
Virtualization:      VT-x
L1d cache:           32K
L1i cache:           32K
L2 cache:            256K
L3 cache:            8192K
NUMA node0 CPU(s):   0-7
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp md_clear flush_l1d