RFR: 8219974: REDO JDK-8219492: Restore static callsite resolution for the current class

David Holmes david.holmes at oracle.com
Tue Mar 5 00:35:59 UTC 2019


Thanks Vladimir!

David

On 5/03/2019 7:53 am, Vladimir Ivanov wrote:
> Looks good.
> 
> Best regards,
> Vladimir Ivanov
> 
> On 03/03/2019 23:17, David Holmes wrote:
>> webrev: http://cr.openjdk.java.net/~dholmes/8219974/webrev/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8219974
>>
>> JDK-8219492 was previously reviewed:
>>
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2019-February/037036.html 
>>
>>
>> and pushed:
>>
>> http://hg.openjdk.java.net/jdk/jdk/raw-rev/86ee52ca11e3
>>
>> but the new assertions failed on a single test that had an 
>> invokespecial call to an interface method for an interface that was 
>> not (and should not be) initialized. So it was backed out.
>>
>> The safest fix is to ensure the new assertions only apply when 
>> considering invoke_static. So that's the only difference between this 
>> version and the original.
>>
>> Testing:
>>    - failing test from tier 4 in regular and Xcomp mode
>>    - tiers 1-3
>>
>> Thanks,
>> David
>> -----


More information about the hotspot-dev mailing list