RFR(S): 8219650: [Testbug] Fix potential crashes in new test hotspot gtest "test_print_hex_dump"

Aleksey Shipilev shade at redhat.com
Wed Mar 6 11:44:18 UTC 2019


On 3/6/19 12:27 PM, Thomas Stüfe wrote:
> Okay next try:
> 
> http://cr.openjdk.java.net/~stuefe/webrevs/8219650-shade-print-hex/webrev.01/webrev/

Looks okay. Boy, what a ride. Thanks for doing this!

*) I have no strong opinion about this, but maybe we would universally call that non-zero address?
It would probably require more work figuring out different bitness, so this one is also good. Maybe
one-line it with AIX_ONLY(...) NOT_AIX(0)?

 188   // On AIX, zero page is readable.
 189   address unreadable =
 190 #ifdef AIX
 191     (address) 0xFFFFFFFFFFFF0000ULL;
 192 #else
 193     (address) 0
 194 #endif
 195     ;

-Aleksey



More information about the hotspot-dev mailing list